MPI_T: add code to check obj_handle arg #13348
Merged
+144
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devreal
reviewed
Jul 28, 2025
|
@devreal could you recheck this? |
devreal
previously approved these changes
Jul 29, 2025
| opal_class_t *opal_class; | ||
| const char *obj_name = NULL; | ||
|
|
||
| /* we are actually evaulating a pointer to an OMPI MPI opaque handle */ |
There was a problem hiding this comment.
Suggested change
| /* we are actually evaulating a pointer to an OMPI MPI opaque handle */ | |
| /* we are actually evaluating a pointer to an OMPI MPI opaque handle */ |
devreal
approved these changes
Jul 29, 2025
Three MPI_T methods - for pvar, cvar, events, can bind one of these objects to an arbitrary MPI object. There was verbiage added to the MPI 4.1 standard which states its erroneous to bind one of these 'T' objects to an invalid MPI object. This PR adds code to make an effort at checking the validity of the arbitrary MPI object argument. We don't bother with events since only a stub implementation is currently present. Related to issue open-mpi#12185. Signed-off-by: Howard Pritchard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three MPI_T methods - for pvar, cvar, events, can bind one of these objects to an arbitrary MPI object.
There was verbiage added to the MPI 4.1 standard which states its erroneous to bind one of these 'T' objects to an invalid MPI object. This PR adds code to make an effort at checking the validity of the arbitrary MPI object argument.
We don't bother with events since only a stub implementation is currently present.
Related to issue #12185.